[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Enable disabled debug messages



On Tue, Dec 07, 2010 at 06:24:45PM +0100, Jiri Denemark wrote:
> ---
>  src/qemu/qemu_conf.c |    2 +-
>  src/qemu/qemu_conf.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index d81e6cc..08c084b 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -1449,7 +1449,7 @@ int qemudParseHelpStr(const char *qemu,
>  
>      *flags = qemudComputeCmdFlags(help, *version, *is_kvm, *kvm_version);
>  
> -    qemudDebug("Version %u.%u.%u, cooked version %u, flags %u",
> +    qemudDebug("Version %u.%u.%u, cooked version %u, flags 0x%llx",
>                 major, minor, micro, *version, *flags);
>      if (*kvm_version)
>          qemudDebug("KVM version %d detected", *kvm_version);
> diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h
> index a1556cb..50938f5 100644
> --- a/src/qemu/qemu_conf.h
> +++ b/src/qemu/qemu_conf.h
> @@ -44,7 +44,7 @@
>  # include "macvtap.h"
>  # include "command.h"
>  
> -# define qemudDebug(fmt, ...) do {} while(0)
> +# define qemudDebug DEBUG
>  
>  # define QEMUD_CPUMASK_LEN CPU_SETSIZE

It'd be preferrable to kill qemudDebug and just use
VIR_DEBUG directly

I'm already doing this in the daemon/ code I'm
currently re-writing. There's just a few instances
left in src/qemu/

Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]