[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] tests: Fix commandtest in VPATH build



On 12/06/2010 05:03 AM, Jiri Denemark wrote:
> ---
>  tests/commandtest.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/commandtest.c b/tests/commandtest.c
> index 48c6335..e8decd3 100644
> --- a/tests/commandtest.c
> +++ b/tests/commandtest.c
> @@ -587,12 +587,15 @@ cleanup:
>  static int test15(const void *unused ATTRIBUTE_UNUSED)
>  {
>      virCommandPtr cmd = virCommandNew(abs_builddir "/commandhelper");
> +    char *cwd = NULL;
>      int ret = -1;
>  
>      if (!cmd)
>          return -1;
>  
> -    virCommandSetWorkingDirectory(cmd, abs_builddir "/commanddata");
> +    if (virAsprintf(&cwd, "%s/commanddata", abs_srcdir) < 0)
> +        goto cleanup;
> +    virCommandSetWorkingDirectory(cmd, cwd);

ACK; I've gone ahead and pushed my rewrite of patch 2 in your series, as
well as the rebase of this patch 3 from your series.

I still haven't tried running commandtest under valgrind to see if there
are any other leaks to plug (so far, it's just been patches by
inspection and prove that the testsuite still passes), but I hope to get
to that point as well.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]