[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 7/8] Convert the remote driver to new RPC client APIs



On 12/01/2010 10:26 AM, Daniel P. Berrange wrote:
> This guts the current remote driver, removing all its networking
> handling code. Instead it calls out to the new virClientPtr and
> virClientProgramPtr APIs for all RPC & networking work.
> ---
>  src/Makefile.am            |    3 +-
>  src/remote/remote_driver.c | 2530 ++++++++------------------------------------
>  2 files changed, 419 insertions(+), 2114 deletions(-)

And here we start to see the real payoff of this series.

>  
> -    if(VIR_ALLOC(priv->callbackList)<0) {
> +    if (VIR_ALLOC(priv->callbackList)<0) {
>          virReportOOMError();
>          goto failed;
>      }
>  
> -    if(VIR_ALLOC(priv->domainEvents)<0) {
> +    if (VIR_ALLOC(priv->domainEvents)<0) {

Can you separate some of this formatting touchups into an independent patch?

> @@ -8165,7 +7442,7 @@ done:
>      return rv;
>  }
>  
> -
> +#if 0
>  static struct private_stream_data *
>  remoteStreamOpen(virStreamPtr st,
>                   int output ATTRIBUTE_UNUSED,
> @@ -8712,7 +7989,7 @@ done:

I see - another case where stream support is missing.

But looking like a nice start.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]