[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Update documentation of watchdog dump option and add test data for it



On 12/09/2010 10:52 PM, Hu Tao wrote:
> The xml watchdog dump option is converted to qemu watchdog pause arg
> but it is not reasonable to convert it back from qemu watchdog pause
> arg since there already is a xml watchdog pause option, so a test for
> the dump option to convert it from arg to xml is not added.
> 
> ---
> I assume the dump option will appear in 0.8.7 and mark it since 0.8.7.

Reasonable assumption; and if we go with 0.9.0 instead, there's several
other places that can all be adjusted at once.

> +++ b/docs/formatdomain.html.in
> @@ -1687,14 +1687,20 @@ qemu-kvm -net nic,model=? /dev/null
>            <li>'poweroff' &mdash; forcefully power off the guest</li>
>            <li>'pause' &mdash; pause the guest</li>
>            <li>'none' &mdash; do nothing</li>
> +          <li>'dump' &mdash; automatic dump the guest
> +            <span class="since">Since 0.8.7</span></li>

s/automatic/automatically/

ACK with that fixed, so I pushed it.  Thanks again for the quick response!

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]