[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [v2] qemu: Introduce two new job types

On 12/13/2010 01:30 AM, Osier Yang wrote:
> Currently, all of domain "save/dump/managed save/migration"
> use the same function "qemudDomainWaitForMigrationComplete"
> to wait the job finished, but the error messages are all
> about "migration", e.g. when a domain saving job is canceled
> by user, "migration was cancled by client" will be throwed as
> an error message, which will be confused for user.
> As a solution, intoduce two new job types(QEMU_JOB_SAVE,
> QEMU_JOB_DUMP), and set "priv->jobActive" to "QEMU_JOB_SAVE"
> before saving, to "QEMU_JOB_DUMP" before dumping, so that we
> could get the real job type in
> "qemudDomainWaitForMigrationComplete", and give more clear
> message further.
> And as It's not important to figure out what's the exact job
> is in the DEBUG and WARN log, also we don't need translated
> string in logs, simply repace "migration" with "job" in some
> statements.

ACK, and pushed.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]