[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] build: properly handle ./configure --with-libpcap



On 12/13/2010 06:44 AM, Diego Elio Pettenò wrote:
> Without this fix, ./configure --with-libpcap will cause --with-libpcap=yes
> to be implicitly passed down, which cause yes/bin/pcap-config to be
> searched for rather than /usr/bin/pcap-config.
> 
> +  AS_CASE(["x$with_libpcap"],
> +    [xno], [LIBPCAP_CONFIG=""],
> +    [x|xyes], [LIBPCAP_CONFIG="pcap-config"],
> +    [LIBPCAP_CONFIG="$with_libpcap/bin/pcap-config"]
> +  )

Oops; AS_CASE is not supported in autoconf 2.59, which means this breaks
builds on RHEL 5.  If you don't beat me to it, I'll submit a patch that
breaks this into a raw shell case statement (AS_CASE is really only
needed when you invoke other autoconf macros inside the case statement,
but this usage does not suffer from any problems where AS_CASE is required).

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]