[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/10] Move QEMU command line management into a separate file



On 12/16/2010 09:50 AM, Daniel P. Berrange wrote:
> The qemu_conf.c code is doing three jobs, driver config file
> loading, QEMU capabilities management and QEMU command line
> management. Move the command line code into its own file
> 
> * src/qemu/qemu_command.c, src/qemu/qemu_command.h: New
>   command line management code
> * src/qemu/qemu_conf.c, src/qemu/qemu_conf.h: Delete command
>   line code
> * src/qemu/qemu_conf.h, src/qemu_conf.c: Adapt for API renames
> * src/Makefile.am: add src/qemu/qemu_command.c
> * src/qemu/qemu_monitor_json.c, src/qemu/qemu_monitor_text.c: Add
>   import of qemu_command.h
> ---
>  src/Makefile.am              |    1 +
>  src/qemu/qemu_command.c      | 5793 ++++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_command.h      |  165 ++
>  src/qemu/qemu_conf.c         | 5748 -----------------------------------------

Wow, more lines moved than in the last patch, but I did due diligence
and did a quick scan for any obvious changes, and didn't find any.

> +static void
> +uname_normalize (struct utsname *ut)
> +{
> +    uname(ut);
> +
> +    /* Map i386, i486, i586 to i686.  */
> +    if (ut->machine[0] == 'i' &&
> +        ut->machine[1] != '\0' &&
> +        ut->machine[2] == '8' &&
> +        ut->machine[3] == '6' &&
> +        ut->machine[4] == '\0')
> +        ut->machine[1] = '6';
> +}

Same nit about sharing this common function with capabilities code.

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]