[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/10] Move QEMU capabilities management into a separate file



On 12/16/2010 11:05 AM, Eric Blake wrote:
> On 12/16/2010 09:50 AM, Daniel P. Berrange wrote:
>> The qemu_conf.c code is doing three jobs, driver config file
>> loading, QEMU capabilities management and QEMU command line
>> management. Move the capabilities code into its own file
>>
>> * src/qemu/qemu_capabilities.c, src/qemu/qemu_capabilities.h: New
>>   capabilities management code
>> * src/qemu/qemu_conf.c, src/qemu/qemu_conf.h: Delete capabilities
>>   code
>> * src/qemu/qemu_conf.h: Adapt for API renames
>> * src/Makefile.am: add src/qemu/qemu_capabilities.c
>> ---
>>  src/Makefile.am              |    1 +
>>  src/qemu/qemu_capabilities.c | 1253 ++++++++++++++++++++++++++++++++++++++++++
>>  src/qemu/qemu_capabilities.h |  113 ++++
>>  src/qemu/qemu_conf.c         | 1191 +---------------------------------------
>>  src/qemu/qemu_conf.h         |   81 ---
>>  src/qemu/qemu_driver.c       |   55 +-

> Other than that nit, ACK - this appeared to be straight code motion plus
> fallout from renaming to a consistent API

Actually, you need to run 'make syntax-check' (missing a change to
po/POTIFILES.in) and 'make check' (qemuxml2argvtest.c fails to compile,
because it isn't including the new qemu_capabilities.h).

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]