[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/6] vbox: Add glue layer for MSCOM on Windows

On 12/17/2010 11:56 AM, Matthias Bolte wrote:
> Don't require dlopen, but link to ole32 and oleaut32 on Windows.

>  if test "x$with_vbox" = "xyes"; then
> -    AC_SEARCH_LIBS([dlopen], [dl], [], [AC_MSG_ERROR([Unable to find dlopen()])])
> +    AC_SEARCH_LIBS([dlopen], [dl],,)
>      case $ac_cv_search_dlopen in
> -      no*) DLOPEN_LIBS= ;;
> +      no*) DLOPEN_LIBS=
> +           case "$host" in
> +             *-*-mingw* | *-*-msvc*) ;;
> +             *) AC_MSG_ERROR([Unable to find dlopen()]) ;;
> +           esac ;;

Sorry for not testing this on cygwin earlier - it breaks, because on
cygwin, dlopen is part of libc, so $ac_cv_search_dlopen is set to "none
required", which happens to match the no*) case.

How about instead doing:

case $ac_cv_search_dlopen:$host in
  no:*-*-mingw* | no:*-*-msvc*) ;;
  no:*) AC_MSG_ERROR([Unable to find dlopen()]) ;;
  *) DLOPEN_LIBS=$ac_cv_search_dlopen ;;

I'm testing that now; if it works, I'll post the formal patch.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]