[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 5/7] tests: avoid spurious failure of nodeinfotest



2010/12/18 Eric Blake <eblake redhat com>:
> When running 'make check' under a multi-cpu Dom0 xen machine,
> nodeinfotest had a spurious failure it was reading from
> /sys/devices/system/cpu, but xen has no notion of topology.  The test
> was intended to be isolated from reading any real system files; the
> regression was introduced in Mar 2010 with commit aa2f6f96dd.
>
> Fix things by allowing an early exit for the testsuite.
>
> * src/nodeinfo.c (linuxNodeInfoCPUPopulate): Add parameter.
> (nodeGetInfo): Adjust caller.
> * tests/nodeinfotest.c (linuxTestCompareFiles): Likewise.
> ---
>  src/nodeinfo.c       |   11 ++++++++---
>  tests/nodeinfotest.c |    5 +++--
>  2 files changed, 11 insertions(+), 5 deletions(-)
>

ACK.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]