[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 10/15] Convert the remote driver to new RPC client APIs



At 12/16/2010 07:22 PM, Daniel P. Berrange Write:
> This guts the current remote driver, removing all its networking
> handling code. Instead it calls out to the new virClientPtr and
> virClientProgramPtr APIs for all RPC & networking work.
> ---
>  src/Makefile.am            |    4 +-
>  src/remote/remote_driver.c | 2596 ++++++++------------------------------------
>  2 files changed, 451 insertions(+), 2149 deletions(-)
> 

<snip>

> +    case trans_ext:
> +        if (!(priv->client = virNetClientNewExternal((const char **)cmd_argv)))
> +            goto failed;
>  

cmd_argv is NULL, we should do init it before calling virNetClientNewExternal():


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]