[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 11/13] Update iptables.c to also support ip6tables.

On 12/22/2010 11:58 AM, Laine Stump wrote:
> All of the iptables functions eventually call down to a single
> bottom-level function, and fortunately, ip6tables syntax (for all the
> args that we use) is identical to iptables format (except the
> addresses), so all we need to do is:
> 1) Get an address family down to the lowest level function in each
>    case, either implied through an address, or explicitly when no
>    address is in the parameter list, and
> 2) At the lowest level, just decide whether to call "iptables" or
>    "ip6tables" based on the family.
> The location of the ip6tables binary is determined at build time by
> autoconf. If a particular target system happens to not have ip6tables
> installed, any attempts to run it will generate an error, but that
> won't happen unless someone tries to define an IPv6 address for a
> network. This is identical behavior to IPv4 addresses and iptables.

>  err6:
>      if (ipv4def && ipv4def->tftproot) {
> -        iptablesRemoveUdpInput(driver->iptables, network->def->bridge, 69);
> +    iptablesRemoveUdpInput(driver->iptables, AF_INET, network->def->bridge, 69);
>      }


ACK with that nit fixed.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]