[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 09/13] Change virtual network XML parsing/formatting to support IPv6



On 12/23/2010 12:09 PM, Eric Blake wrote:
On 12/23/2010 01:31 AM, Laine Stump wrote:
+    int nips;
s/int/size_t/
Okay, I've changed it. I'll point out that the great majority of the
"n<thing>s" variables in *_conf.h are defined as int (and some more as
unsigned int). Should these all be standardized at some point?
Probably, but not high priority.

I was going to attach a delta diff, but realized after the fact that I
didn't know how to get a diff between an old and new version of a commit
once I'd rebased. Instead, I'm pasting the new regexp below for you to
review; that's the only significant change. The others have all been
squashed in as well.
Fair enough.

Agree to ACK for now, and we can further fix the regex later (to fix the
noted problem with accepting :1.2.3.4 - too loose rng is not a
show-stopper for actually using valid IPv6 in XML) [hmm - can you tell
that this is a big enough series that I'd like to get it in before 0.8.7
to widen the test coverage?].

Yes!

Me too.

+1

AOL++

<Whatever other method exists to empatically agree with you>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]