[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: add -incoming fd:n capability checking



2010/12/22 Eric Blake <eblake redhat com>:
> * src/qemu/qemu_capabilities.h (QEMUD_CMD_FLAG_MIGRATE_QEMU_FD):
> New enum value.
> * src/qemu/qemu_capabilities.c (qemuCapsComputeCmdFlags): Populate
> flags according to qemu version.
> * tests/qemuhelptest.c (mymain): Adjust test.
> ---
>
> I feel a bit dirty relying on just a version test for whether
> -incoming fd:n is supported, but it's no different than the
> existing code for -incoming unix:path which was added about the
> same time.  Unfortunately, 'qemu -help' doesn't list which
> particular protocols it supports for -incoming.
>
>  src/qemu/qemu_capabilities.c |    6 +++++-
>  src/qemu/qemu_capabilities.h |    1 +
>  tests/qemuhelptest.c         |   12 ++++++++----
>  3 files changed, 14 insertions(+), 5 deletions(-)
>

ACK.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]