[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] spec: Really skip tests that don't work in mock build root



> > diff --git a/libvirt.spec.in b/libvirt.spec.in
> > index fd99a54..3889f5d 100644
> > --- a/libvirt.spec.in
> > +++ b/libvirt.spec.in
> > @@ -700,8 +700,12 @@ cd tests
> >  for i in nodeinfotest daemon-conf seclabeltest
> >  do
> >    rm -f $i
> > -  printf "#!/bin/sh\nexit 0\n" > $i
> > -  chmod +x $i
> > +  if [ -f $i.c ]; then
> > +    echo 'int main(void) { return 0; }' > $i.c
> > +  else
> > +    printf "#!/bin/sh\nexit 0\n" > $i
> > +    chmod +x $i
> > +  fi
> 
> Do these tests still fail in the latest incarnation?  For example, I'm
> assuming that this upstream patch was enough to fix the nodeinfotest
> failure:
> https://www.redhat.com/archives/libvir-list/2010-December/msg00737.html

Hmm, looks like that patch helps with this. Perhaps we don't need to skip any
test. Self-NACK for the time being. I'll check current state of all tests and
send updated patch.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]