[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: fix building error when building without libvirtd



On 12/23/2010 11:21 PM, Wen Congyang wrote:
> When I build libvirt without libvirtd, I receive some errors:
> cp: cannot stat `/home/wency/rpmbuild/BUILDROOT/libvirt-0.8.6-1.el6.x86_64/etc/libvirt/qemu/networks/default.xml': No such file or directory
> 
> My build step:
> # ./autogen.sh --without-libvirtd
> # make dist
> # rpmbuild --nodeps --define "_sourcedir `pwd`" --define "_without_libvirtd 1" -ba libvirt.spec
> 
> The reason is we disable network when we do not build libvirt daemon in configure.ac.
> After fixing this bug, I build libvirt without libvirtd, I receive other errors:
> RPM build errors:
>     Installed (but unpackaged) file(s) found:
>    /usr/share/doc/libvirt-0.8.6/html/32favicon.png
>    /usr/share/doc/libvirt-0.8.6/html/api.html
> ...
> 

>  
> +# there's no use compiling the network driver without
> +# the libvirt daemon
> +%if ! %{with_libvirtd}
> +%define with_network 0
> +%endif

ACK - this makes the spec file logic match the configure.ac logic.

> +
>  Summary: Library providing a simple virtualization API
>  Name: libvirt
>  Version: @VERSION@
> @@ -667,6 +673,8 @@ rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/libvirt-%{version}
>  
>  %if ! %{with_libvirtd}
>  rm -rf $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/nwfilter
> +mv $RPM_BUILD_ROOT%{_datadir}/doc/libvirt-%{version}/html \
> +   $RPM_BUILD_ROOT%{_datadir}/doc/libvirt-devel-%{version}/
>  %endif

I'm not as confident about this hunk, but since I was able to reproduce
your problem without it and also that it fixed things, I'm okay with it
(if anyone else has a complaint, we can fix it as a followup patch).

Pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]