[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] update docs for network disks



On 12/24/2010 04:41 AM, MORITA Kazutaka wrote:
> Signed-off-by: MORITA Kazutaka <morita kazutaka lab ntt co jp>
> ---
>  docs/formatdomain.html.in |   49 ++++++++++++++++++++++++++++++++++++++++++--
>  1 files changed, 46 insertions(+), 3 deletions(-)

Thanks for picking this up.

> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index cfd3451..86c2d0d 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -628,23 +628,39 @@
>          ...
>        &lt;/serial&gt;
>      &lt;/disk&gt;
> +      ...
> +    &lt;disk type='network'&gt;
> +      &lt;driver name="qemu" type="raw"/&gt;
> +      &lt;source protocol="sheepdog" name="image_name"&gt;
> +        &lt;host name="hostname" port="7000"&gt;

missing / before &gt;

> +        disks. The <code>type</code> attribute is either "file", "block", "dir", or "network"

Long line; I broke it (and several others) to fit in 80 columns.

> +        <span class="since">Since 0.0.3; "device" attribute since 0.1.4;
> +        "network" attribute value since after 0.8.6 (QEMU and KVM only)</span></dd>

I simplified the wording slightly:

Since 0.0.3; "device" attribute since 0.1.4; "network" attribute since 0.8.7

ACK; I pushed after fixing those nits.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]