[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: improve efficiency of dd during snapshots



On Wed, Dec 22, 2010 at 22:06, Eric Blake <eblake redhat com> wrote:
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index 7877731..284f9c4 100644
> --- a/src/qemu/qemu_monitor_json.c
> +++ b/src/qemu/qemu_monitor_json.c
> @@ -1695,10 +1695,11 @@ int qemuMonitorJSONMigrateToFile(qemuMonitorPtr mon,
>      * <> redirection to avoid truncating a regular file.  */
>     if (virAsprintf(&dest, "exec:" VIR_WRAPPER_SHELL_PREFIX "%s | "
>                     "{ dd bs=%llu seek=%llu if=/dev/null && "
> -                    "dd bs=%llu; } 1<>%s" VIR_WRAPPER_SHELL_SUFFIX,
> +                    "dd ibs=%llu; obs=%llu } 1<>%s" VIR_WRAPPER_SHELL_SUFFIX,

typo: semicolon before obs. Should be:
                    "dd ibs=%llu obs=%llu } 1<>%s" VIR_WRAPPER_SHELL_SUFFIX,

-- 
Pawel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]