[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: avoid excess parens in STREQ



According to Eric Blake on 1/27/2010 6:59 AM:
> * src/internal.h (STREQ, STRCASEEQ, STRNEQ, STRCASENEQ, STREQLEN)
> (STRCASEEQLEN, STRNEQLEN, STRCASENEQLEN, STRPREFIX): Avoid
> redundant parenthesis.
> * examples/domain-events/events-c/event-test.c (STREQ): Likewise.
> * src/storage/parthelper.c (STREQ): Likewise.
> ---
> These macros were originally inspired by Jim Meyering, who has since made
> this same cleanup elsewhere.  For example:
> http://lists.gnu.org/archive/html/bug-gnulib/2010-01/msg00293.html
> 
...
> -#define STREQ(a,b) (strcmp((a),(b)) == 0)
> +#define STREQ(a,b) (strcmp(a,b) == 0)

Ping.

By the way, should the web pages mention that libvirt-list is an alias for
libvir-list for symmetry reasons, particularly now that we have the
libvirt-user list?

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9 byu net


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]