[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 09/13] Remove direct storage of hostnet_name & vlan



On Tue, Feb 02, 2010 at 03:01:46PM +0000, Daniel P. Berrange wrote:
> On Tue, Feb 02, 2010 at 03:58:19PM +0100, Daniel Veillard wrote:
> > On Mon, Feb 01, 2010 at 06:39:38PM +0000, Daniel P. Berrange wrote:
> > > The current way of assigning names to the host network backend and
> > > NIC device in QEMU was over complicated, by varying naming scheme
> > > based on the NIC model and backend type. This simplifies the naming
> > > to simply be 'net0' and 'hostnet0', allowing code to easily determine
> > > the host network name and vlan based off the primary device alias
> > > name 'net0'. This in turn allows removal of alot of QEMU specific
> > > code from the XML parser, and makes it easier to assign new unique
> > > names for NICs that are hotplugged
> > > 
> > 
> >   ACK, this really simplifies the code, but isn't there a small risk of
> > not being able to properly handle domains say after a libvirt upgrade
> > and restart ?
> 
> Yes & no. Any guests that were running before the upgrade will continue
> to run fine. You won't be able to hotplug further NICs to those guests
> until you restart them though. I did try to maintain the ability to
> hotplug into running guests after an upgrade, but it was getting more
> complex than I could cope with due to the really wierd naming scheme
> used by the old code.

  Okay, yes there is a very small tradeoff there but I think it's the
right things to do,

  thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]