[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/5] macvtap support for libvirt -- helper code




"Daniel P. Berrange" <berrange redhat com> wrote on 02/08/2010 12:03:53 PM:


>
> This method can be removed, since it is just duplicating the
> functionality of the code generated by the VIR_ENUM_DECL
> declaration in the XML parsing code you have.
>

I will probably have to have a translation function to convert the integers to the enums understood by the driver.

> > +create_name:
> > +        retries = 5;
> > +        for (c = 0; c < 255; c++) {
>
> This that an abslute limit on number of MACVTAP devices, or can we
> raise this somewhat higher ?  We recently had to remove a similarly
> low hardcoded limit in number of plain TAP devices. If we cna make
> this 1024 or more, that'd be great


I don't think there is such a limit. I will raise the number to 1024 or higher.

Thanks and regards,
    Stefan

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]