[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/9] virDomain{Attach, Detach}DeviceFlags patches



Daniel P. Berrange wrote:
> On Mon, Feb 08, 2010 at 05:16:25PM -0500, Chris Lalancette wrote:
>   
>> I suspect you have to run "cd src ; make rpcgen", and then check the resulting
>> src/remote/remote_protocol.c and src/remote/remote_protocol.h into the
>> repository to get things to work again.
>>     
>
> Yep, don't worry about this - I've re-generated & pushed the files
>   

Oops.  I was wondering how the generated rpc files were handled but then
forgot to ask before committing the patches.  So whenever
remote_protocol.x is modified, developer must regenerate
remote_protocol.[ch] and include those in the corresponding patch
correct?  I can send a patch to update the "API extensions" doc but want
to make sure I understand the process correctly.

Thanks,
Jim


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]