[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/9] virDomain{Attach, Detach}DeviceFlags patches



On Tue, Feb 09, 2010 at 09:03:53AM -0700, Jim Fehlig wrote:
> Daniel P. Berrange wrote:
> > On Mon, Feb 08, 2010 at 05:16:25PM -0500, Chris Lalancette wrote:
> >   
> >> I suspect you have to run "cd src ; make rpcgen", and then check the resulting
> >> src/remote/remote_protocol.c and src/remote/remote_protocol.h into the
> >> repository to get things to work again.
> >>     
> >
> > Yep, don't worry about this - I've re-generated & pushed the files
> >   
> 
> Oops.  I was wondering how the generated rpc files were handled but then
> forgot to ask before committing the patches.  So whenever
> remote_protocol.x is modified, developer must regenerate
> remote_protocol.[ch] and include those in the corresponding patch
> correct?  I can send a patch to update the "API extensions" doc but want
> to make sure I understand the process correctly.

Yes, that is correct. Also note that this causes some of the server side
files in daemon/ to be re-generated too


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]