[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 8/8] Annotate some virConnectPtr as mandatory non-null



On Wed, Feb 10, 2010 at 01:36:26PM +0000, Daniel P. Berrange wrote:
> Use the ATTRIBUTE_NONNULL annotation to mark some virConnectPtr
> args as mandatory non-null so the compiler can warn of mistakes
> 
> * src/conf/domain_event.h: All virConnectPtr args must be non-null
> * src/qemu/qemu_conf.h: qemudBuildCommandLine and
>   qemudNetworkIfaceConnect() must be given non-null connection
> * tests/qemuxml2argvtest.c: Provide a non-null (dummy) connection to
>   qemudBuildCommandLine()
> ---
>  src/conf/domain_event.h  |   13 +++++++++----
>  src/qemu/qemu_conf.h     |    6 ++++--
>  tests/qemuxml2argvtest.c |    8 +++++++-
>  3 files changed, 20 insertions(+), 7 deletions(-)
> 

  ACK, good idea !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]