[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/9] virConnectBaselineCPU public API



On Fri, Feb 05, 2010 at 04:56:53PM +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark <jdenemar redhat com>
> ---
>  include/libvirt/libvirt.h.in |   18 ++++++++++++++++++
>  src/libvirt_public.syms      |    5 +++++
>  2 files changed, 23 insertions(+), 0 deletions(-)
> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index f192fb1..0a96a04 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -1756,6 +1756,24 @@ int virConnectCompareCPU(virConnectPtr conn,
>                           unsigned int flags);
>  
>  
> +/**
> + * virConnectBaselineCPU:
> + *
> + * @conn: virConnect connection
> + * @ncpus: number of CPUs in xmlCPUs
> + * @xmlCPUs: array of XML descriptions of host CPUs
> + * @flags: fine-tuning flags
> + *
> + * Computes the most feature-rich CPU which is compatible with all given
> + * host CPUs.
> + *
> + * Returns XML description of the computed CPU or NULL on error.
> + */
> +char *virConnectBaselineCPU(virConnectPtr conn,
> +                            unsigned int ncpus,
> +                            const char **xmlCPUs,
> +                            unsigned int flags);

Can we switch this one to to have 'ncpus' after xmlCPUs too.

> +
>  #ifdef __cplusplus
>  }
>  #endif
> diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms
> index 0521158..bb4963b 100644
> --- a/src/libvirt_public.syms
> +++ b/src/libvirt_public.syms
> @@ -349,4 +349,9 @@ LIBVIRT_0.7.5 {
>          virDomainMemoryStats;
>  } LIBVIRT_0.7.3;
>  
> +LIBVIRT_0.7.7 {
> +    global:
> +        virConnectBaselineCPU;
> +} LIBVIRT_0.7.5;
> +
>  # .... define new API here using predicted next version number ....
> -- 

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]