[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/9] New public API for computing baseline CPU



On Fri, Feb 05, 2010 at 04:56:49PM +0100, Jiri Denemark wrote:
> Hi,
> 
> This series introduces a new virConnectBaselineCPU() API call for
> computing baseline CPU model from a set of host CPU definitions.
> The call accepts a list of <cpu>...</cpu> xml definitions taken from
> host capabilities and returns an xml description of a guest CPU which is
> supported by all hosts.
> 
> virsh is little bit less picky and accepts a file containing host CPU
> definitions. It doesn't care what is outside of the <cpu/> tag, which
> allows for concatenating outputs of virsh capabilities from several
> hosts and feeding the result to virsh cpu-baseline.
> 
> This series can also be found on cpu-baseline branch of
> git://gitorious.org/~jirka/libvirt/jirka-staging.git

It all looks pretty good to me.  Did the python code generator
handle this correctly though ? I'm surprised if it did, because
it normally screws up on any API involving arrays.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]