[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix USB device path formatting mixup



On Thu, Feb 11, 2010 at 02:40:26PM +0000, Daniel P. Berrange wrote:
> * src/util/hostusb.c: The device path for a USB device wants the
>   bus/device IDs in decimal not octal
> ---
>  src/util/hostusb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/util/hostusb.c b/src/util/hostusb.c
> index 3cce66b..bf96539 100644
> --- a/src/util/hostusb.c
> +++ b/src/util/hostusb.c
> @@ -184,7 +184,7 @@ usbGetDevice(unsigned bus,
>      snprintf(dev->name, sizeof(dev->name), "%.3o:%.3o",
>               dev->bus, dev->dev);
>      snprintf(dev->path, sizeof(dev->path),
> -             USB_DEVFS "%03o/%03o", dev->bus, dev->dev);
> +             USB_DEVFS "%03d/%03d", dev->bus, dev->dev);
>  
>      /* XXX fixme. this should be product/vendor */
>      snprintf(dev->id, sizeof(dev->id), "%d %d", dev->bus, dev->dev);

  ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]