[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Mark all error messages for translation



On Thu, Feb 11, 2010 at 04:27:26PM +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark <jdenemar redhat com>
> ---
>  src/conf/storage_conf.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
> index eb1c9d9..2352637 100644
> --- a/src/conf/storage_conf.c
> +++ b/src/conf/storage_conf.c
> @@ -1464,7 +1464,7 @@ virStoragePoolObjLoad(virStoragePoolObjListPtr pools,
>  
>      if (!virFileMatchesNameSuffix(file, def->name, ".xml")) {
>          virStorageReportError(VIR_ERR_INVALID_STORAGE_POOL,
> -                              "Storage pool config filename '%s' does not match pool name '%s'",
> +                              _("Storage pool config filename '%s' does not match pool name '%s'"),
>                                path, def->name);
>          virStoragePoolDefFree(def);
>          return NULL;
> @@ -1524,7 +1524,7 @@ virStoragePoolLoadAllConfigs(virStoragePoolObjListPtr pools,
>          if (virFileBuildPath(configDir, entry->d_name,
>                               NULL, path, PATH_MAX) < 0) {
>              virStorageReportError(VIR_ERR_INTERNAL_ERROR,
> -                                  "Config filename '%s/%s' is too long",
> +                                  _("Config filename '%s/%s' is too long"),
>                                    configDir, entry->d_name);
>              continue;
>          }
> @@ -1532,7 +1532,7 @@ virStoragePoolLoadAllConfigs(virStoragePoolObjListPtr pools,
>          if (virFileBuildPath(autostartDir, entry->d_name,
>                               NULL, autostartLink, PATH_MAX) < 0) {
>              virStorageReportError(VIR_ERR_INTERNAL_ERROR,
> -                                  "Autostart link path '%s/%s' is too long",
> +                                  _("Autostart link path '%s/%s' is too long"),
>                                    autostartDir, entry->d_name);
>              continue;
>          }

  Yup raised by "make syntax-check", ACK,

  BTW the rule is that if something breaks "make", "make check" or
"make syntax-check", it's fine to commit the fix first (assuming it's
not controversial i.e. something patchform specific)

 thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]