[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/9] Functions for computing baseline CPU from a set of host CPUs



On Thu, Feb 11, 2010 at 07:45:40PM +0100, Jiri Denemark wrote:
> > > +    for (i = 0; i < ncpus; i++) {
> > > +        doc = xmlParseMemory(xmlCPUs[i], strlen(xmlCPUs[i]));
> > > +        if (doc == NULL || (ctxt = xmlXPathNewContext(doc)) == NULL)
> > > +            goto no_memory;
> > 
> >    Hum, no, doc == NULL might come from parsing error, raising an OOMError
> > in that case sounds weird, unless you're 100% sure this is well formed
> > XML...
> 
> Hmm, right. If you don't mind I will address this separately together with
> similar older code.

  Yeah, sure !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]