[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] qemu: Make Set*Mem commands hotplug only



On Mon, Feb 15, 2010 at 12:33:53PM +0100, Matthias Bolte wrote:
> 2010/2/12 Cole Robinson <crobinso redhat com>:
> > SetMem and SetMaxMem are hotplug only APIs, any persistent config
> > changes are supposed to go via XML definition. The original implementation
> > of these calls were incorrect and had the nasty side effect of making
> > a psuedo persistent change that would be lost after libvirtd restart
> > (I didn't know any better).
> >
> > Fix these APIs to rightly reject non running domains.
> > ---
> 
> Could you document this somewhere that virDomainSetMaxMemory may be
> called for active domains only, like in the documentation of
> virDomainSetMaxMemory in libvirt.c?
> 
> Several details of the libvirt API are only documentation deep down in
> the mailing list, or the developers heads.
> 
> Now you've fixed the code to do what is supposed to do, but it's still
> not documented well.
> 
> The same goes for the other commit where you made it callable for an
> active domain only.

FYI, I also have a test case that's intended to validate methods which
should only be called on running domains. If anyone wants to submit
patches for API calls which are missing in my current list....
  
  http://libvirt.org/git/?p=libvirt-tck.git;a=blob;f=scripts/domain/090-invalid-ops-when-inactive.t;hb=HEAD

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]