[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] network: bridge: Fix IsActive, IsPersistent



On Tue, Feb 16, 2010 at 02:37:01PM -0500, Cole Robinson wrote:
> We were accessing the wrong private data structure, which would
> cause a segfault.
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  src/network/bridge_driver.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
> index 8cef714..4453707 100644
> --- a/src/network/bridge_driver.c
> +++ b/src/network/bridge_driver.c
> @@ -1188,7 +1188,7 @@ static int networkListDefinedNetworks(virConnectPtr conn, char **const names, in
>  
>  static int networkIsActive(virNetworkPtr net)
>  {
> -    struct network_driver *driver = net->conn->privateData;
> +    struct network_driver *driver = net->conn->networkPrivateData;
>      virNetworkObjPtr obj;
>      int ret = -1;
>  
> @@ -1209,7 +1209,7 @@ cleanup:
>  
>  static int networkIsPersistent(virNetworkPtr net)
>  {
> -    struct network_driver *driver = net->conn->privateData;
> +    struct network_driver *driver = net->conn->networkPrivateData;
>      virNetworkObjPtr obj;
>      int ret = -1;
>  
> -- 
ACK


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]