[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virBufferVSprintf: do not skip va_end



According to Jim Meyering on 2/19/2010 3:45 AM:
>>   Hum, that one I'm not sure. In the case of virBufferGrow failure,
>> we just did va_end(locarg); in the loop before, so going to cleanup
>> there does it twice, and I'm not sure it's legal. Probably simpler to
>> add just va_end(argptr); before return in that case and drop the
>> cleanup: target.
> 
> Good catch.  Corrected, as you suggest:
> 
> +++ b/.gnulib
> @@ -1 +1 @@
> -Subproject commit 11fbc57405a118e6ec9a3ebc19bbf5ececdae4d6
> +Subproject commit a1d565aa5b47ec56243e74d4ac8b4988a751fef2

Why the change in .gnulib?  Shouldn't that be an independent patch?

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9 byu net

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]