[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: fix typos in configure-set makefile variable names



Richard W.M. Jones wrote:

> On Wed, Feb 24, 2010 at 12:08:01PM +0100, Jim Meyering wrote:
>> Without this change, the ..._MODULES_... variables are set
>> in configure.ac, but never used.
>>
>> The variables that are actually used in src/Makefile.am
>> are named _MODULE_...
>
> ACK, the patch is reasonable.

Thanks.

> However it still doesn't fix the current build failure for me on
> Rawhide:
>
> make[3]: Entering directory `/home/rjones/d/libvirt/tests'
>   CC     virshtest.o
>   CC     testutils.o
>   CCLD   virshtest
>   CC     conftest.o
>   CCLD   conftest
>   CC     nodeinfotest.o
>   CCLD   nodeinfotest
> /usr/bin/ld: ../src/.libs/libvirt_test.a(libvirt_driver_vbox_la-vbox_XPCOMCGlue.o): undefined reference to symbol 'dlclose@@GLIBC_2.2.5'
> /usr/bin/ld: note: 'dlclose@@GLIBC_2.2.5' is defined in DSO /lib64/libdl.so.2 so try adding it to the linker command line
> /lib64/libdl.so.2: could not read symbols: Invalid operation
> collect2: ld returned 1 exit status
>
> Just adding -ldl to the end of LDADDS in tests/Makefile.am fixes this
> problem for me, but I'm not sure if that is the correct way to fix it.

That sounds reasonable, if we're guaranteed always to have a libdl.
However, the fact that it's not needed on F12 suggests that we should
be adding it only when necessary (hence a configure-time test).

I hit that same problem a few hours ago, but haven't yet gotten to it.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]