[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Avoid searching for windres when not building for cygwin or mingw.



On Wed, Feb 24, 2010 at 04:04:30PM +0100, Diego Elio Pettenò wrote:
> Just checking for a windres tool might hit even on Linux systems when
> building for Linux (e.g.: when using Gentoo and having built binutils with
> multitarget support), and will then fail to link properly at the end of the
> build.
> 
> Check the host string before deciding whether to look for windres or not.
> ---
>  configure.ac |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 117cb20..5b1eb5f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1682,8 +1682,13 @@ AC_SUBST([CYGWIN_EXTRA_PYTHON_LIBADD])
>  AC_SUBST([MINGW_EXTRA_LDFLAGS])
>  
>  dnl Look for windres to build a Windows icon resource.
> -AC_CHECK_TOOL([WINDRES], [windres], [no])
> -AM_CONDITIONAL([WITH_WIN_ICON], [test "$WINDRES" != "no"])
> +case "$host" in
> +  *cygwin* | *mingw* )
> +    AC_CHECK_TOOL([WINDRES], [windres], [])
> +    ;;
> +esac
> +
> +AM_CONDITIONAL([WITH_WIN_ICON], [test "$WINDRES" != ""])

>From the POV of cross-compilation, this looks fine.  ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]