[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] Fix build of the VirtualBox driver when using --no-add-needed.



On Wed, Feb 24, 2010 at 04:04:33PM +0100, Diego Elio Pettenò wrote:
> With the recent changes to the linking defaults in Fedora 13 (namely
> enabling --no-add-needed behaviour by default), we have to pass the
> dlopen()-providing libraries directly at the link of the module; use the
> newly introduced macro to look for it and add it to the Makefile.
> ---
>  configure.ac    |    1 +
>  src/Makefile.am |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4a848cd..804db90 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -303,6 +303,7 @@ fi
>  AM_CONDITIONAL([WITH_OPENVZ], [test "$with_openvz" = "yes"])
>  
>  if test "x$with_vbox" = "xyes"; then
> +    AFX_LIB_DLOPEN
>      AC_DEFINE_UNQUOTED([WITH_VBOX], 1, [whether VirtualBox driver is enabled])
>  fi
>  AM_CONDITIONAL([WITH_VBOX], [test "$with_vbox" = "yes"])
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 46acb7d..87fe65c 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -464,6 +464,7 @@ libvirt_driver_vbox_la_CFLAGS = \
>  if WITH_DRIVER_MODULES
>  libvirt_driver_vbox_la_LDFLAGS = -module -avoid-version
>  endif
> +libvirt_driver_vbox_la_LIBADD = $(DLOPEN_LIBS)
>  libvirt_driver_vbox_la_SOURCES = $(VBOX_DRIVER_SOURCES)
>  endif

ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]