[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Avoid searching for windres when not building for cygwin or mingw.



According to Diego Elio Pettenò on 2/24/2010 8:44 AM:
> -AC_CHECK_TOOL([WINDRES], [windres], [no])
> -AM_CONDITIONAL([WITH_WIN_ICON], [test "$WINDRES" != "no"])
> +case "$host" in

Redudant quotes. The shell word after case is never subject to field
splitting, so it is sufficient to use:

case $host in

> +  *cygwin* | *mingw* )
> +    AC_CHECK_TOOL([WINDRES], [windres], [])
> +    ;;
> +  *)
> +    WINDRES=""

This works, but if it were me, I would remove the redundant quotes and write:

WINDRES=

> +    ;;
> +esac
> +
> +AM_CONDITIONAL([WITH_WIN_ICON], [test "$WINDRES" != ""])

But you now have my ACK, whether or not you strip the redundant ".

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]