[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] build: avoid non-srcdir installation failure (apibuild.py)



According to Jim Meyering on 2/24/2010 6:20 AM:
> Running "make distcheck" from a non-srcdir build was failing like this:
> 
>     /bin/sh: ./apibuild.py: No such file or directory
> 
> Fixed that with the first patch below (the apibuild.py script
> is not in ".", but in $(srcdir)).
> 
> Then retrying, it got a little further but failed like this:
> 
>     (../../docs/apibuild.py)
>     make[3]: *** No rule to make target `sitemap.html.in', needed by `html/index.html'.  Stop.
> 
> That was because sitemap.html.in was not being distributed.
> Adding it to EXTRA_DIST solved that:

ACK to both patches, but a question...

> @@ -131,7 +131,7 @@ devhelp/index.html devhelp/libvirt.devhelp: libvirt-api.xml $(devhelpxsl)
>  libvirt-api.xml libvirt-refs.xml: apibuild.py \
>  		$(srcdir)/../include/libvirt/*.h \
>  		$(srcdir)/../src/libvirt.c $(srcdir)/../src/util/virterror.c
> -	-(./apibuild.py)
> +	-($(srcdir)/apibuild.py)

Why the subshell?

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]