[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Use AC_SEARCH_LIBS to find the library to use for dlopen().



According to Diego Elio Pettenò on 2/24/2010 8:36 AM:
> Instead of using AC_CHECK_LIB and hardcoding -ldl, search for the library
> needed to get dlopen() and then use the cached value.
> -  DRIVER_MODULES_LIBS="-ldl"
> +  DRIVER_MODULES_LIBS="$ac_cv_search_dlopen"

Does this properly handle the case of 'no' or 'none required'?  I think
you need:

case $ac_cv_search_dlopen in
  no*) DRIVER_MODULES_LIBS= ;;
  *) DRIVER_MODULES_LIBS=$ac_cv_search_dlopen ;;
esac

By the way, shell assignment is another case where no field splitting is
performed, so your use of "" was redundant.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]