[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Take Two - Fix domain restore for files on root-squash NFS.



According to Laine Stump on 2/24/2010 1:58 PM:
> (This version incorporates the suggestions from Jim Meyering and Eric Blake)

I guess that line is okay to leave in the commit message.  If it had been
me, though, I would have left it out of the commit log, and just inserted
it between the --- and diffstat during 'git send-email --annotate' - it is
relevant to the thread that explains the updated commit and how it differs
from the first attempt, but it is not really related to the patch itself.
 After all, at the end of the day, the original version of this patch will
not be in libvirt.git, so the words "This version" no longer have any
context for comparison.  Likewise, a subject line of "[PATCHv2] Fix..." is
better than "[PATCH] Take Two - Fix...", since git am strips
"[PATCH...]" but not "Take Two".

> 
> If qemudDomainRestore fails to open the domain save file, create a
> pipe, then fork a process that does setuid(qemu_user) and opens the
> file, then reads this file and stuffs it into the pipe. the parent
> libvirtd process will use the other end of the pipe as its fd, then
> reap the child process after it's done reading.
> 

ACK - you fixed everything I brought up, and the patch itself looks good.

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9 byu net

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]