[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] openvzGetVEID: don't leak (memory + file descriptor)



According to Jim Meyering on 2/25/2010 12:01 PM:
>> You're still keeping with fscanf.
> 
> Yes.  There are plenty of bigger fish to fry, for now ;-)
> As it is, this is more of a rearrangement than I generally
> prefer "just to fix a leak".

Indeed, I have no problem with checking in your patch as-is, and saving
the *scanf cleanups for a separate patch.

> 
> If we could magically remove all uses of *scanf, atoi, etc.,
> that'd be great ;-)  But making so many changes is a little
> risky now, considering how little test coverage we have.

Sounds like I've just volunteered myself for a beginner's project then.
It may be a while (and probably should wait until after the current
release), but it seems like a patch series that addresses dangerous
constructs one place at a time would be worthwhile, both in improving the
code base and in getting me familiar with more than just the autotools
input files.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]