[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] build: avoid warning about return-with-value in void function



I saw this:

    virsh.c: In function 'virshReportError':
    virsh.c:363: warning: 'return' with a value, in function returning void


>From fc83f08ac204cec5fba474a23bd19386d1a415d7 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering redhat com>
Date: Fri, 26 Feb 2010 11:50:34 +0100
Subject: [PATCH] build: avoid warning about return-with-value in void function

* tools/virsh.c: Just "return;", not "return NULL;".
---
 tools/virsh.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index f7fd7d4..3b1011c 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -360,7 +360,7 @@ virshReportError(vshControl *ctl)
          * no error was ever raised, so just ignore */
         last_error = virSaveLastError();
         if (!last_error || last_error->code == VIR_ERR_OK)
-            return NULL;
+            return;
     }

     if (last_error->code == VIR_ERR_OK) {
--
1.7.0.442.g55ad1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]