[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] fix build failure with --disable-shared



Diego Elio “Flameeyes” Pettenò wrote:
> Il giorno gio, 07/01/2010 alle 21.14 +0100, Jim Meyering ha scritto:
>>
>> The change below reverts 8838ee39ab1c2bb7fffe93bfda220692664e8be6,
>> so Diego, if your goal (with the reverted change) was more than to
>> avoid seemingly-unnecessary work, please tell us what it was.
>
> Well, to put it simply: you *cannot* both have the Python extension
> *and* disable shared libraries.
>
> --disable-shared tells libtool not to build any kind of shared object
> for the project; Python extensions are shared objects _only_.
>
> While you could avoid building libvirt.so (and just have libvirt.a) you
> cannot get Python extensions by just building libvirtmod.a.
>
> So basically --disable-shared --with-python would just produce an
> unusable output without my change, and produce a proper error condition
> with.

But --disable-shared is useful, and your change broke it.
As such, I can't see how you would be using --disable-shared.
Does the proposed patch cause you any difficulty?
If so, please tell us what/how, or propose an alternate patch.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]