[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] node_device: udev: Fix memory leak



On 01/12/2010 03:26 PM, Cole Robinson wrote:
We are setting the same property two different ways without
free'ing in between. Just drop the second assignment.

Signed-off-by: Cole Robinson<crobinso redhat com>
---
  src/node_device/node_device_udev.c |    6 +-----
  1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
index a9e196d..ff6bd46 100644
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -997,11 +997,7 @@ static int udevProcessStorage(struct udev_device *device,
          goto out;
      }
      data->storage.block = strdup(devnode);
-    if (udevGetStringProperty(device,
-                              "DEVNAME",
-&data->storage.block) == PROPERTY_ERROR) {
-        goto out;
-    }
+
      if (udevGetStringProperty(device,
                                "ID_BUS",
                                &data->storage.bus) == PROPERTY_ERROR) {

Good catch.  ACK.

Dave


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]