[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] Support bond interfaces attached to bridges in interface xml.



On 01/01/2010 08:40 PM, Laine Stump wrote:

> +
> +    if (((parentIfType == VIR_INTERFACE_TYPE_BOND)
> +         && (type != VIR_INTERFACE_TYPE_ETHERNET))
> +        || ((parentIfType == VIR_INTERFACE_TYPE_BRIDGE)
> +            && (type != VIR_INTERFACE_TYPE_ETHERNET)
> +            && (type != VIR_INTERFACE_TYPE_BOND)
> +            && (type != VIR_INTERFACE_TYPE_VLAN))
> +        || (parentIfType == VIR_INTERFACE_TYPE_ETHERNET)
> +        || (parentIfType == VIR_INTERFACE_TYPE_VLAN))
> +        {
> +        virInterfaceReportError(conn, VIR_ERR_XML_ERROR,
> +                                _("interface has unsupported type '%s'"), type);
> +        goto error;
> +    }

Actually, I just built and the above line produces an error. 'type' is an int,
so can't be formatted with '%s'.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]