[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/34] Convert monitor over to use virDomainDeviceAddress



On Fri, Jan 08, 2010 at 05:23:03PM +0000, Daniel P. Berrange wrote:
> Convert the QEMU monitor APIs over to use virDomainDeviceAddress
> structs for passing addresses in/out, instead of individual bits.
> This makes the number of parameters smaller & easier to deal with.
> No functional change
> 
> * src/qemu/qemu_driver.c, src/qemu/qemu_monitor.c,
>   src/qemu/qemu_monitor.h, src/qemu/qemu_monitor_text.c,
>   src/qemu/qemu_monitor_text.h: Change monitor hotplug APIs to
>   take an explicit address ptr for all host/guest addresses
> ---
>  src/qemu/qemu_driver.c       |   35 +++++++++---------------
>  src/qemu/qemu_monitor.c      |   60 ++++++++++++------------------------------
>  src/qemu/qemu_monitor.h      |   21 +++-----------
>  src/qemu/qemu_monitor_json.c |   55 +++++++++++++++++---------------------
>  src/qemu/qemu_monitor_json.h |   22 +++------------
>  src/qemu/qemu_monitor_text.c |   56 ++++++++++++++-------------------------
>  src/qemu/qemu_monitor_text.h |   22 +++------------
>  7 files changed, 90 insertions(+), 181 deletions(-)

  ACK, makes the code way nicer !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]