[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 18/34] Add device info to serial, parallel, channel, input & fs devices



On Fri, Jan 08, 2010 at 05:23:14PM +0000, Daniel P. Berrange wrote:
> Although the serial, parallel, chanel, input & fs devices do
> not have PCI address info, they can all have device aliases.
> Thus it neccessary to associate the virDomainDeviceInfo data
> with them all.
> 
> * src/conf/domain_conf.c, src/conf/domain_conf.h: Add hooks for
>   parsing / formatting device info for serial, parallel, channel
>   input and fs devices.
> * docs/schemas/domain.rng: Associate device info with character
>   devices, input & fs device
> ---
>  docs/schemas/domain.rng |   12 ++++++++
>  src/conf/domain_conf.c  |   67 ++++++++++++++++++++++++++++++++++++++--------
>  src/conf/domain_conf.h  |    4 +++
>  3 files changed, 71 insertions(+), 12 deletions(-)
> 
> diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
> index a32ce45..f4bef7b 100644
> --- a/docs/schemas/domain.rng
> +++ b/docs/schemas/domain.rng
> @@ -600,6 +600,9 @@
>            </interleave>
>          </group>
>        </choice>
> +      <optional>
> +	<ref name="address"/>
> +      </optional>
>      </element>
>    </define>
>    <define name="filesystemtgt">
> @@ -990,6 +993,9 @@
>            </optional>
>          </element>
>        </optional>
> +      <optional>
> +	<ref name="address"/>
> +      </optional>
>      </interleave>
>    </define>
>    <define name="qemucdevSrcType">
> @@ -1119,6 +1125,9 @@
>        <interleave>
>          <ref name="qemucdevSrcDef"/>
>          <ref name="guestfwdTarget"/>
> +	<optional>
> +	  <ref name="address"/>
> +	</optional>
>        </interleave>
>      </element>
>    </define>
> @@ -1139,6 +1148,9 @@
>            </choice>
>          </attribute>
>        </optional>
> +      <optional>
> +	<ref name="address"/>
> +      </optional>
>      </element>
>    </define>
>    <define name="hostdev">

  Hum, unless I'm mistaken this also allow to add a PCI like address
on input even if it would be ignored, maybe this should be tightened to
just allow the info

otherwise looks fine

  ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]