[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 31/34] Add support for explicit -sdl flag to QEMU



On Fri, Jan 15, 2010 at 09:00:36PM +0100, Daniel Veillard wrote:
> On Fri, Jan 08, 2010 at 05:23:27PM +0000, Daniel P. Berrange wrote:
> > Not all QEMU builds default to SDL graphics for their display.
> > Newer QEMU now has an explicit -sdl flag, which we can use to
> > explicitly request SDL intead of relying on the default. This
> > protects libvirt against unexpected changes in graphics default
> > 
> 
> >      if (def->nvideos) {
> > diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h
> > index 174d397..4a862d1 100644
> > --- a/src/qemu/qemu_conf.h
> > +++ b/src/qemu/qemu_conf.h
> > @@ -79,6 +79,7 @@ enum qemud_cmd_flags {
> >      QEMUD_CMD_FLAG_MONITOR_JSON  = (1 << 24), /* JSON mode for monitor */
> >      QEMUD_CMD_FLAG_BALLOON       = (1 << 25), /* -balloon available */
> >      QEMUD_CMD_FLAG_DEVICE        = (1 << 26), /* Is the new -chardev arg available */
> > +    QEMUD_CMD_FLAG_SDL           = (1 << 27), /* Is the new -sdl arg available */
> >  };
> 
>   Aren't we getting close to the 32 options limits ?

It doesn't really matter as we can trivially just make it an int64, or
turn it into a plain enum, instead of bitflags. This isn't exposed in
the API anywhere

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]