[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/4] A bit of configure clear-up



On Sun, Jan 17, 2010 at 02:21:37AM +0100, Diego Elio Petten? wrote:
> Since on the whole it seems like the configure could see some cleanup, as
> it seem to use lots of older constructs and repeated code, I tried doing
> some basic cleaning.

Agreed, that it is in need of some cleanup. One of the ideas I've thought
about is to split up the configure.ac script into a set of macros since 
the main file is faaaar to large now eg in the m4/ directory we could have

   check-qemu.m4
   check-xen.m4
   check-storage.m4
   check-...
   ...etc..

.. one file for each logically indepdant block of m4 code from configure.ac
Then, in the configure.ac file we'd just end up with a set of single line
calls into these files loooking like

  LIBVIRT_CHECK_QEMU
  LIBVIRT_CHECK_XEN
  LIBVIRT_CHECK_STORAGE
  ....

this should make it much easier to follow what's going on in the configure.ac
script

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]