[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Add VNC support



2010/1/17 Daniel P. Berrange <berrange redhat com>:
> On Sat, Jan 16, 2010 at 03:22:19PM +0100, Matthias Bolte wrote:
>> * src/conf/domain_conf.c: add defaults for the video device
>> * src/esx/esx_vmx.[ch]: add VNC support to the VMX handling
>> * tests/vmx2xmltest.c, tests/xml2vmxtest.c: add tests for the VNC support
>> ---
>>  src/conf/domain_conf.c                     |    5 +
>>  src/esx/esx_vmx.c                          |  146 +++++++++++++++++++++++++++-
>>  src/esx/esx_vmx.h                          |    6 +
>>  tests/vmx2xmldata/vmx2xml-graphics-vnc.vmx |    6 +
>>  tests/vmx2xmldata/vmx2xml-graphics-vnc.xml |   17 +++
>>  tests/vmx2xmltest.c                        |    4 +-
>>  tests/xml2vmxdata/xml2vmx-graphics-vnc.vmx |   11 ++
>>  tests/xml2vmxdata/xml2vmx-graphics-vnc.xml |   11 ++
>>  tests/xml2vmxtest.c                        |    2 +
>>  9 files changed, 203 insertions(+), 5 deletions(-)
>>  create mode 100644 tests/vmx2xmldata/vmx2xml-graphics-vnc.vmx
>>  create mode 100644 tests/vmx2xmldata/vmx2xml-graphics-vnc.xml
>>  create mode 100644 tests/xml2vmxdata/xml2vmx-graphics-vnc.vmx
>>  create mode 100644 tests/xml2vmxdata/xml2vmx-graphics-vnc.xml
>>
[...]
>> diff --git a/tests/xml2vmxtest.c b/tests/xml2vmxtest.c
>> index dfaca02..530dd2a 100644
>> --- a/tests/xml2vmxtest.c
>> +++ b/tests/xml2vmxtest.c
>> @@ -173,6 +173,8 @@ mymain(int argc, char **argv)
>>      DO_TEST("minimal", "minimal", esxVI_APIVersion_25);
>>      DO_TEST("minimal-64bit", "minimal-64bit", esxVI_APIVersion_25);
>>
>> +    DO_TEST("graphics-vnc", "graphics-vnc", esxVI_APIVersion_25);
>> +
>>      DO_TEST("scsi-buslogic", "scsi-buslogic", esxVI_APIVersion_25);
>>      DO_TEST("scsi-writethrough", "scsi-writethrough", esxVI_APIVersion_25);
>>
>> --
>
> ACK, this is nice - it sould mean that you can connect to ESX guest consoles
> in virt-manager now
>
>
> Daniel
>

Yes, that should be possible for domains defined through libvirt.
Domains created using the VMware VI client won't work yet because they
won't have VNC configured by default. To enable VNC for them one needs
to virDomanAttachDevice a VNC graphics device or re-virDomainDefineXML
an existing domain to add the graphics device. Unfortunately both ways
are not yet implemented in the ESX driver.

Thanks, pushed.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]