[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 09/12] Fix security driver calls in hotplug cleanup paths



On Wed, Jan 20, 2010 at 03:15:06PM +0000, Daniel P. Berrange wrote:
> The hotplug code was not correctly invoking the security driver
> in error paths. If a hotplug attempt failed, the device would
> be left with VM permissions applied, rather than restored to the
> original permissions. Also, a CDROM media that is ejected was
> not restored to original permissions. Finally there was a bogus
> call to set hostdev permissions in the hostdev unplug code
> 
> * qemu/qemu_driver.c: Fix security driver usage in hotplug/unplug
> ---
>  src/qemu/qemu_driver.c |  177 +++++++++++++++++++++++++++++++++---------------
>  1 files changed, 123 insertions(+), 54 deletions(-)

> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 22b6adc..5054bcf 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -5126,6 +5126,11 @@ static int qemudDomainChangeEjectableMedia(virConnectPtr conn,

  Okay the refactoring for error handling of the functions is not trivial
to follow but looks fine,

  ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]